Revert "Fixed issue where unsigned values were displayed as signed"

beardypig / ghidra-emotionengine

Ghidra Processor for the Play Station 2's Emotion Engine MIPS based CPU

Apache License 2.0

198 stars 35 forks source link

Revert "Fixed issue where unsigned values were displayed as signed" #69

Closed JayFoxRox closed 3 years ago

JayFoxRox commented 3 years ago

Reverts beardypig/ghidra-emotionengine#55

See my arguments in

https://github.com/beardypig/ghidra-emotionengine/issues/53#issuecomment-856677822: Assumption of original change was incorrect
https://github.com/beardypig/ghidra-emotionengine/pull/55#issuecomment-856695827: Change caused many issues (Example 1)
https://github.com/beardypig/ghidra-emotionengine/issues/63#issuecomment-856670166: Change caused many issues (Example 2)

astrelsky commented 3 years ago

It turns out that you are correct. I'm terribly sorry about this. This is exactly why naming things properly is important. Add immediate unsigned should do exactly as the name implies but in reality it doesn't.

Just to be on the safe side considering I did approve the pr that caused the issue I will wait for @beardypig to merge this.

astrelsky commented 3 years ago

Thinking about this again, it should have been obvious that it should be signed from looking at a function entry addiu sp, -0x10. Although it really doesn't make sense for the instruction to be "add immediate unsigned" but I digress.