search

beardypig / ghidra-emotionengine

Ghidra Processor for the Play Station 2's Emotion Engine MIPS based CPU
Apache License 2.0
200 stars 34 forks source link

Ghidra 10.0 support #71

Closed astrelsky closed 3 years ago

astrelsky commented 3 years ago

I'm not sure what the values should be for the CI. I am also uncertain what branch this should go in as it breaks support for all versions < Ghidra 10.0.

Resolves #70

beardypig commented 3 years ago

There is an issue with the CI builder for Ghidra 10 that needs to be resolved. It might be worth setting up a more complicated branch structure to handled the major versions of Ghidra, I will make some time to look at it later today or over the weekend.

SpaceDog61 commented 3 years ago

Any news about the support of the Ghidra 10?

astrelsky commented 3 years ago

Any news about the support of the Ghidra 10?

You may use this in the meantime if you'd like. I did some manual renaming after building so if it is broken lmk.

ghidra_10.0_PUBLIC_20210710_ghidra-emotionengine.zip

JayFoxRox commented 3 years ago

You may use this in the meantime if you'd like. I did some manual renaming after building so if it is broken lmk.

The linked file does not seem to work for me in Ghidra 10.0.2 (Arch Linux package ghidra-10.0.2-1).

There is an issue with the CI builder for Ghidra 10 that needs to be resolved.

Was this related to the changes in how Ghidra is published, or something else? Since your comment, there have been changes to the CI script that we use: https://github.com/er28-0652/setup-ghidra/commit/78856978c498ab739b64cf4ed8b25c6e7b7740b7

Ghidra 10.x has been out for a while now, too. So it's very unfortunate that the latest release of this plugin is not up-to-date.

Edit: I still wasn't able to build ghidra-emotionengine locally (any branch), so I used GitHub actions to build it for 10.0.2 now: https://github.com/JayFoxRox/ghidra-emotionengine/releases/tag/vUnknown-10.x

VelocityRa commented 3 years ago

@beardypig Can you please merge this? Ghidra 10 has been out for 3 months at this point.

Risae commented 3 years ago

@astrelsky Will this also support the new Ghidra releases? (10.0+)

astrelsky commented 3 years ago

@astrelsky Will this also support the new Ghidra releases? (10.0+)

Of course.

https://github.com/astrelsky/ghidra-emotionengine/releases/tag/latest

Risae commented 3 years ago

@astrelsky Thank you very much!