search

beardypig / ghidra-emotionengine

Ghidra Processor for the Play Station 2's Emotion Engine MIPS based CPU
Apache License 2.0
200 stars 34 forks source link

Fix for Ghidra v10.2.x #81

Closed HarmfulBreeze closed 1 year ago

HarmfulBreeze commented 1 year ago

Get ConstructTpl directly from PcodeParser#compilePcode since stringifyTemplate is gone. (c.f. https://github.com/NationalSecurityAgency/ghidra/commit/aa038c363609fe13402c71516ebf7277fdac864e) Closes #80.

VelocityRa commented 1 year ago

Bump. @beardypig Is the repo dead? Is there an active fork somewhere?

Or maybe someone can send a built zip of this? I'm getting gradle errors.

wagrenier commented 1 year ago

For the time being, since the repo owner has not been active publicly since September, a fork could be made where active development could continue. If the owner comes back it could be merged or be designated as the new official version.

@VelocityRa I know you have a lot of experience with playstation hardware from your work on the Vit emulator and PCSX2, so would you mind maintaining an active fork of this project? I would not mind doing it myself but I lack technical knowledge in PS2 and MIPS to maintain it and correctly review the PR.

VelocityRa commented 1 year ago

@wagrenier I've contributed to RPCS3 and Vita3K, not PCSX2. My PS2 work has been mostly reverse engineering / modding games, plus I don't really have experience developing Ghidra extensions. I think @astrelsky would be a much better fit for this, if he's willing.

raSTARgfx commented 1 year ago

Yeah would love to see some movement on this. @ziemas was kind enough to throw a build to the requesting parties. Looking through the history though it seems @astrelsky already has merge access.

astrelsky commented 1 year ago

@beardypig has been awall for a few years now. It is very convenient to be unable to remove myself as a collaborator. Unfortunately I don't have as much free time as I used to.

I had gone back and ported the vector instructions back to being fully implemented in sleigh. It just hasn't been put through it's paces.

As far as this pull request goes, if there is no response from @beardypig I'll probably just merge it as is.

wagrenier commented 1 year ago

Could we make a fork with a different name and add a comment to it in the readme? That way people will be aware of a new and actively updated version.

I wouldn't mind maintain it, but I would give access to someone else with good knowledge of PS2 specs

chaoticgd commented 1 year ago

I've been using a modified version of ghidra-emotionengine for about a year now with all the VU stuff reverted to my initial PR. I've been hesitant to make a pull request since it does remove functionality (micro mode) and is generally very unfinished, although I have been trying to get back to working on it recently. If no one's taken up the torch by the time I'm done I could release it as a proper fork.

astrelsky commented 1 year ago

I've been using a modified version of ghidra-emotionengine for about a year now with all the VU stuff reverted to my initial PR. I've been hesitant to make a pull request since it does remove functionality (micro mode) and is generally very unfinished, although I have been trying to get back to working on it recently. If no one's taken up the torch by the time I'm done I could release it as a proper fork.

In the branch where I converted the macro mode stuff to sleigh I'm pretty sure I just said to hell with it and left the micro mode instructions unimplemented.

raSTARgfx commented 1 year ago

+1 @chaoticgd if willing.

We're more than happy to accommodate a fork over at Gundorada Workshop for interested parties. Just throwing out the offer.

wagrenier commented 1 year ago

https://github.com/beardypig/ghidra-emotionengine/issues/82 https://github.com/chaoticgd/ghidra-emotionengine-reloaded

New active repo for the addon! @chaoticgd