search

beardypig / streamlink-portable

A script to build a portable version of Streamlink for Windows
Apache License 2.0
77 stars 18 forks source link

Latest Nightly build release failed... #18

Closed Vangelis66 closed 3 years ago

Vangelis66 commented 3 years ago

Happy New Year @beardypig 😄

I am watching the Nightly portable build releases since a while ago and just became aware that the usual, daily, GitHub e-mail titled [beardypig/streamlink-portable] Pre-release latest - Nightly Build from github-actions[bot] is AWOL... 😞 That would've been announcing the availability of streamlink-portable-2.0.0+16.g7b74974-py3.6.5-win32.zip

I browsed the Actions tab and regrettably saw that the build creation has failed:

SL-Nightly_fail

Perhaps recent repo activity has somehow broken things? These portable builds of yours are highly appreciated 👍 , as the other portable streamlink package has been sadly abandoned 😭 ...

While I'm at it, would you mind if I asked some related questions?

  1. PSF has 3.6.8-win32 binaries available, can these be used instead of 3.6.5?
  2. Would it be hard to move to latest py3.7 (3.7.9 to be exact)?
  3. What is the underlying reason some modules are "frozen" at older versions (e.g. pycryptodome-3.4.3 used, latest being 3.9.9)?

Many thanks, my heartfelt wishes for 2021, stay healthy and safe wherever you happen to be...

beardypig commented 3 years ago

Yes, it broke. I noticed it broke and took a look, but I didn't see a way to fix it quickly. I planned to look at it tomorrow.

Updating to 3.7.9 is easy and I will do it.

The versions were frozen at the time when I made it to maintain compatibility pre-2.0.0, they could be updated now to match the current versions used by streamlink 2.0.0.

beardypig commented 3 years ago

I have updated the Python version and the dependencies, I just need to fix that pesky nightly build issue.

beardypig commented 3 years ago

For some reason the merge commit was making the auto-release fail.

Vangelis66 commented 3 years ago

I'm sorry to spoil it again for you, ... but the archive's filename still mentions Python 3.6.5 :

NR

Vangelis66 commented 3 years ago

... And does still contain Python 3.6.5 in its guts:

py365

I think I have opened a can of worms... :disappointed:

beardypig commented 3 years ago

Actually for real will be 3.7.9, forgot it set the Python version in the action workflow too...

Vangelis66 commented 3 years ago

Thanks... at long last! :tada: Apologies I made you work overtime/overnight... :smiley:

One last thing: __pycache__ folders inside the new py3.7.9 archive (./streamlink/packages/*) still contain compiled files (*.pyc) from py3.6.5, also some other remnant files reference py3.6, should these be removed or will cause no harm?

P1 P2

beardypig commented 3 years ago

That's weird, maybe from caching on github... they shouldn't do any harm though and will probably disappear in a couple of days worth of nightly builds anyway.

Vangelis66 commented 3 years ago

__pycache__ folders inside the new py3.7.9 archive (./streamlink/packages/*) still contain compiled files (*.pyc) from py3.6.5, also some other remnant files reference py3.6,

I see now this was, most probably, addressed by https://github.com/beardypig/streamlink-portable/commit/612b929ca350f1e17e71887843de72b1afd0b8f4 :+1: Thanks for your perseverance! :smile:

beardypig commented 3 years ago

yeah it probably was that :)