beardypig / streamlink-portable

A script to build a portable version of Streamlink for Windows
Apache License 2.0
77 stars 18 forks source link

Getting the portable version to work with Daisuki.net #7

Closed starchivore closed 7 years ago

starchivore commented 7 years ago

Good Day,

I've been using this Daisuki plugin for many months:

https://gist.github.com/intact/3d6af5f361c1a44fd878

Simply changing a few things from:

from livestreamer.compat import urljoin, urlparse, urlunparse
from livestreamer.exceptions import PluginError
from livestreamer.plugin import Plugin
from livestreamer.plugin.api import http, validate
from livestreamer.plugin.api.utils import parse_json
from livestreamer.stream import HLSStream

To:

from streamlink.compat import urljoin, urlparse, urlunparse
from streamlink.exceptions import PluginError
from streamlink.plugin import Plugin
from streamlink.plugin.api import http, validate
from streamlink.plugin.api.utils import parse_json
from streamlink.stream import HLSStream

The "plain vanilla" version of Streamlink is working fine with WinPython 3.5.2.3 and PyCryptodome 3.4.5 so far:

image

However, I built the Standalone EXE version of Streamlink Portable and that seemed to be no go:

image

Tried CrunchyRoll instead and it's OK:

image

Replaced the entire folder %TMP%\RTV_STREAMLINK_FOR_WINDOWS\Streamlink\Crypto with the counterpart taken from that WinPython 3.5.2.3 + PyCryptodome 3.4.5 as mentioned above:

image

There's gotta be a way to integrate PyCryptodome and I'm just wondering how that Standalone EXE should be built in the first place without showing any errors at all.

Thank you very much for your help and have a great day.

beardypig commented 7 years ago

I think this is the wrong portable version, it looks like you're after https://github.com/streamlink/streamlink-portable/

beardypig commented 7 years ago

I have created a PR to merge the daisuki plugin in to streamlink: https://github.com/streamlink/streamlink/pull/609. It also adds the feature of being able to automatically include the subtitles by adding --daisuki-mux-subtitles.

beardypig commented 7 years ago

@starchivore is this fixed with the plugin in streamlink or are you still have trouble with it?

starchivore commented 7 years ago

It's all good now, many thanks for your help and please kindly close this.