bearsunday / BEAR.Package

A BEAR.Sunday framework component package
https://packagist.org/packages/bear/package
MIT License
30 stars 26 forks source link

Use BEAR/Resource ResourceObjectModule #414

Closed NaokiTsuchiya closed 1 year ago

NaokiTsuchiya commented 1 year ago

概要


BEAR\Package\Module\ResourceObjectModule は deprecated にもできますが、 NullPage の束縛も行っていたので内部で BEAR\Resource\Module\ResourceObjectModule をインストールする形にしています。

Psalm 5 から array shape の sealed と unsealed を区別するようになったのでその対応をしていますが、依存パッケージからimport type しているものは依存パッケージ側の修正が必要のため suppress させています 66829b31231c11a2776fa053f0672a5966c99e05

参考: https://psalm.dev/articles/psalm-5

unsealed のための記法が phpcs においてエラーと検知されているので、そちらも合わせて ignore しています。 3deedd995b9760d727605d7aad91a021fb38a11a

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.87% // Head: 99.87% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (3deedd9) compared to base (087bb44). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.x #414 +/- ## ========================================= Coverage 99.87% 99.87% Complexity 243 243 ========================================= Files 54 54 Lines 812 814 +2 ========================================= + Hits 811 813 +2 Misses 1 1 ``` | [Impacted Files](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday) | Coverage Δ | | |---|---|---| | [src/Compiler/CompileClassMetaInfo.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL0NvbXBpbGVyL0NvbXBpbGVDbGFzc01ldGFJbmZvLnBocA==) | `100.00% <ø> (ø)` | | | [src/Compiler/FakeRun.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL0NvbXBpbGVyL0Zha2VSdW4ucGhw) | `100.00% <ø> (ø)` | | | [src/Injector/FileUpdate.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL0luamVjdG9yL0ZpbGVVcGRhdGUucGhw) | `100.00% <ø> (ø)` | | | [src/Module/ImportSchemeCollectionProvider.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL01vZHVsZS9JbXBvcnRTY2hlbWVDb2xsZWN0aW9uUHJvdmlkZXIucGhw) | `100.00% <ø> (ø)` | | | [src/Provide/Router/RouterCollectionProvider.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL1Byb3ZpZGUvUm91dGVyL1JvdXRlckNvbGxlY3Rpb25Qcm92aWRlci5waHA=) | `100.00% <ø> (ø)` | | | [src/Provide/Router/WebRouter.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL1Byb3ZpZGUvUm91dGVyL1dlYlJvdXRlci5waHA=) | `100.00% <ø> (ø)` | | | [src/Module/ResourceObjectModule.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL01vZHVsZS9SZXNvdXJjZU9iamVjdE1vZHVsZS5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Provide/Error/Status.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL1Byb3ZpZGUvRXJyb3IvU3RhdHVzLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Provide/Router/CliRouter.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL1Byb3ZpZGUvUm91dGVyL0NsaVJvdXRlci5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Provide/Router/HttpMethodParams.php](https://codecov.io/gh/bearsunday/BEAR.Package/pull/414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL1Byb3ZpZGUvUm91dGVyL0h0dHBNZXRob2RQYXJhbXMucGhw) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.