bearsunday / BEAR.Package

A BEAR.Sunday framework component package
https://packagist.org/packages/bear/package
MIT License
30 stars 26 forks source link

CompileApp #423

Closed koriym closed 4 months ago

koriym commented 1 year ago

Compilerの代替です。Injectorを渡すと以下のコンパイルが行われます。

(アノテーションのキャッシュは行われません)

 $injector = Injector::getInstance();
 (new CompileApp())->compile($injector);

コンテキスト配列を渡すと他のコンテキストでもDI/AOPファイルの生成が行われます。

 (new CompileApp())->compile($injector, ['prod-api-app', 'prod-html-app']);

最初のヘルスチェックに一度だけ行う事を想定しています。

背景

Compilerはディプロイ前のCLIでの実行を想定して作成されました。CompileAppはCLIとともにwebでのヘルスチェックでも使えるように実行速度を求めてよりコンパクトになったものです。またPHP8アトリビュートの普及によりアノテーションのコンパイルも取り除かれています。

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4bee375) 100.00% compared to head (f2730b7) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.x #423 +/- ## =========================================== Coverage 100.00% 100.00% - Complexity 243 254 +11 =========================================== Files 54 55 +1 Lines 817 856 +39 =========================================== + Hits 817 856 +39 ``` | [Files Changed](https://app.codecov.io/gh/bearsunday/BEAR.Package/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday) | Coverage Δ | | |---|---|---| | [src/Compiler/CompileApp.php](https://app.codecov.io/gh/bearsunday/BEAR.Package/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bearsunday#diff-c3JjL0NvbXBpbGVyL0NvbXBpbGVBcHAucGhw) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

koriym commented 9 months ago

@NaokiTsuchiya Gentle reminder

koriym commented 5 months ago

@coderabbitai review

coderabbitai[bot] commented 5 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot] commented 5 months ago
Walkthrough ## Walkthrough The recent changes introduce updates to the `composer.json` file, including namespace adjustments and script modifications. A new namespace `FakeVendor\MinApp` is added with related classes and modules. Additionally, a new `CompileApp` class and its test case are introduced to handle application compilation, dependency injection, and parameter meta information. ## Changes | File(s) | Change Summary | |---------|----------------| | `composer.json` | Updated paths for namespaces, added new namespace `FakeVendor\MinApp`, and modified `coverage` and `pcov` scripts to use `./vendor/bin/phpunit`. | | `src/Compiler/CompileApp.php` | Introduced `CompileApp` class for application compilation with methods for compiling resources and handling extra contexts. | | `tests/CompileAppTest.php` | Added `CompileAppTest` class to test the compilation process of `CompileApp`. | | `tests/Fake/fake-min-app/composer.json` | Updated to include `bear/package` version `^1.16` and autoloading for `FakeVendor\Compile`. | | `tests/Fake/fake-min-app/src/Module/App.php` | Introduced `App` class implementing `AppInterface` with constructor injection. | | `tests/Fake/fake-min-app/src/Module/AppModule.php` | Added `AppModule` class extending `AbstractModule` and configuring dependencies using `PackageModule`. | | `tests/Fake/fake-min-app/src/Resource/Page/Index.php` | Added `Index` class extending `ResourceObject` with a constructor and `onGet` method. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
koriym commented 5 months ago

@coderabbitai review

coderabbitai[bot] commented 5 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.