beast-dev / beast-mcmc

Bayesian Evolutionary Analysis Sampling Trees
http://beast.community
GNU Lesser General Public License v2.1
192 stars 73 forks source link

allMus with unequal weights clashes with Dirichlet prior #1021

Closed GuyBaele closed 7 months ago

GuyBaele commented 6 years ago

For example, the Ebola data set has 4 weights in total, with the weight for the intergenic region partition differing from the 3 weights of the codon positions. A deltaExchange combined with a Dirichlet prior (which we have been suggesting as of late) rejects all changes to ig.mu, given its different weight from the other positions (see screenshot).

screen shot 2018-09-02 at 20 51 13

The easiest way to fix this or make it more robust could be to simply use equal weights for all partitions, which in this case eliminates the problem:

screen shot 2018-09-02 at 21 12 32

maxbiostat commented 6 years ago

I thought we switched to the mu parametrisation exactly to escape DeltaExchange with unequal weights. What am I missing?

rambaut commented 6 years ago

Yes. Dirichlet can only be used if the delta exchange has equal weights. Which means it can't be used on unequal sized partitions. Hence the switch to _nu_s which have been adjust for the partition size and thus can use an equal delta exchange. But the logger rescales these back to _mu_s for easy interpretation.

GuyBaele commented 6 years ago

So I assume we keep things as they are for now, and eventually get rid of the 'return to classic priors' checkbox?

rambaut commented 6 years ago

Yes. But perhaps we should throw a parser error to help clarify this.

GuyBaele commented 6 years ago

Sounds like a plan.

rambaut commented 7 months ago

Got rid of classic prior option