STL operator doesn't produce same sequence with the same seed.

beast-dev / beast-mcmc

Bayesian Evolutionary Analysis Sampling Trees

http://beast.community

GNU Lesser General Public License v2.1

192 stars 73 forks source link

STL operator doesn't produce same sequence with the same seed. #1040

Closed rambaut closed 6 years ago

rambaut commented 6 years ago

Two runs with attached XML, with -seed 666.

First run finishes with:

10000000    -193385.9824    -106.4902       -193279.4922    0.49856         0.48 hours/million states

Second run:

10000000    -193392.4949    -107.5974       -193284.8975    0.51533         0.44 hours/million states

carnivores.HKYG.SC.CPC.STL1.xml.txt

rambaut commented 6 years ago

The runs diverge by the first reported state (i.e., state 1000).

rambaut commented 6 years ago

Caused by use of HashMap returning a different order of nodes that were being picked randomly. Switched to a LinkedHashMap to maintain insertion order.