beast-dev / beast-mcmc

Bayesian Evolutionary Analysis Sampling Trees
http://beast.community
GNU Lesser General Public License v2.1
181 stars 69 forks source link

Parsing error for BEAUTi-generated xml file for directional random walk model #1083

Open mlewinsohn opened 4 years ago

mlewinsohn commented 4 years ago

I am interested in comparing location traits inferred with the directional random walk model with other continuous trait models implemented in BEAST. I generated the xml file using the same data and parameters that have worked for other models and got the following error in BEAST:

SEVERE: Parsing error - poorly formed BEAST file, CC_sim_directional_template.xml:
The '<strictClockBranchRates>' element, nested within an element with id, 'location.traitLikelihood', is incorrectly constructed.
The following was expected:
Exactly one ELEMENT of name rate REQUIRED containing
    Exactly one ELEMENT of type Parameter REQUIRED
Error thrown at: dr.xml.AbstractXMLObjectParser.parseXMLObject(Unknown Source)

I am using BEAUti v1.10.4 and BEAST v1.10.4

Here is an example xml file generated in BEAUti that reproduces the error: https://drive.google.com/file/d/1DvTepifUANyqB7ttwn9S-gbQbYQZaepj/view?usp=sharing

pbastide commented 4 years ago

Thank you for opening an issue. We are currently working on improving support for continuous trait models in BEAUTi, so any feedback is welcome.

I committed what should be a fix for this problem in branch trait_beauti, that is still under active development. The fix should appear in a future version of the software.

In the meantime, here is a modified xml, that should work with the current version of BEAST.

Thank you, Best, Paul

mlewinsohn commented 4 years ago

Hi Paul,

Thanks so much, the modified xml worked perfectly.

Best, Maya