beastsaber / bsaber

https://bsaber.com
9 stars 9 forks source link

Add one click download buttons where applicable #74

Closed TimothyGillespie closed 5 months ago

netlify[bot] commented 6 months ago

Deploy Preview for bsaber ready!

Built without sensitive environment variables

Name Link
Latest commit 4f40ffe52a8484a9da825e637428734d329c9809
Latest deploy log https://app.netlify.com/sites/bsaber/deploys/6619c5c5b778f70008b3d590
Deploy Preview https://deploy-preview-74--bsaber.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Pixelguymm commented 5 months ago

I don't mind this idea, though I think a general download feature would probably be better. You could have a dropdown including a normal download and OneClick. Also, the positions of the buttons feel very out of place in both cases.

TimothyGillespie commented 5 months ago

I'll try the other variations later. I did have the one for maps in the empty space as you've describe before, but since it's very disconnected it doesn't have a strong connection to the rest which is not surprising there is only continuity/experience that weakly lend it the impression to be part of the map, here is a screenshot:

image

Putting them right next to the diff just seems silly as they are not in the same position. Although, perhaps I could fix the location of the button according to a max size on the diff? Maybe that's better. I haven't tried that yet.

I didn't quite understand the idea with "on top of the image though".

TimothyGillespie commented 5 months ago

Might solve #88 and #89.

Pixelguymm commented 5 months ago

I didn't quite understand the idea with "on top of the image though".

This is what I had in mind, but upon seeing it, I'm not too sure anymore: image