search

beastsaber / bsaber

https://bsaber.com
9 stars 9 forks source link

Add collaborators to MOTW #75

Closed Pixelguymm closed 5 months ago

Pixelguymm commented 6 months ago

I had to turn off all formatters I could think of, as formatting will create whitespace where there shouldn't be whitespace.

netlify[bot] commented 6 months ago

Deploy Preview for bsaber ready!

Name Link
Latest commit c1a79119c36d409cf8c0bef8a63b899581ec5516
Latest deploy log https://app.netlify.com/sites/bsaber/deploys/660d609d5d0f8d000831655d
Deploy Preview https://deploy-preview-75--bsaber.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TimothyGillespie commented 5 months ago

I think this currently breaks because the map of the week list doesn't receive any collaborators from its +page.server.ts.

This would be solved if you push the collaborators in here: https://github.com/beastsaber/bsaber/blob/4e42d2ac7e236069877d027807f812eb777e6c41/src/routes/maps-of-the-week/%5Bpage%5D/%2Bpage.server.ts#L46

And add them to the data with the lookup similar to the uploader. Since every page holds 15 maps and the API allows a maximum of ids at once (and I don't have any logic that would allow handling more as of now) you could play it safe an easy by decreasing the pageSize to 10. That allows for 5 uploaders per map on average. That should be pretty safe.

https://github.com/beastsaber/bsaber/blob/4e42d2ac7e236069877d027807f812eb777e6c41/src/routes/maps-of-the-week/%5Bpage%5D/%2Bpage.server.ts#L4

I hope the code is not dense! Sorry if it is!

TimothyGillespie commented 5 months ago

Looks good to me. The server side for map of the week is so much prettier now :laughing: