search

beat-machine / beat-webapp

Webapp for The Beat Machine
https://beatmachine.branchpanic.me/
MIT License
11 stars 3 forks source link

🐞 Bug: Beats are often numbered with an "offset" #34

Open JustACuteGirlLookingForAManToFixHerBugs opened 4 years ago

JustACuteGirlLookingForAManToFixHerBugs commented 4 years ago

Hey! I've noticed it often doesn't properly "number" the beats - so if I try to remove every second beat it removes 1st 3rd and so on. Same for the swaps - I often have to add Offset 2 to get it work.

I thought maybe it gets confused by some silence in the beginning - but to contrary, on a demo loop that starts right away it always removed the first one when I removed every 2nd beat.

"Don't Speak" by No Doubt doesn't render properly for example. But it's better to test with simple demo tracks to catch the issue.

dhsavell commented 4 years ago

Thanks for the report! I'll see what I can do, although unfortunately it might be a bit before I get around to redeploying. Out of curiosity does offset 1 work as you'd expect with the remove effect, switching from 1st/3rd to 2nd/4th? I think there might be an off-by-one error somewhere.