beat / tracker-apps

Joomla Apps* bugtracker
GNU General Public License v2.0
0 stars 0 forks source link

Sort by Ratings not sorting same as on JED #27

Closed beat closed 10 years ago

beat commented 10 years ago

As reported here: https://groups.google.com/forum/#!topic/joomla-dev-cms/c_-u1JOdlSE

JED seems to have "votes DESC" as second criteria on equality of average (e.g. 5.0).

I will check with JED what the exact criteria is for the sorting.

beat commented 10 years ago

Reply from JED:

I think it is rating and then ID (so lowest ID is above, when same rating). And they start counting when 5 or more votes. Under that, only by ID, I think.

beat commented 10 years ago

So converted to SQL as just explained by @nonumber:

First for those with at least 5 votes: Ratings count first, by equality, number of votes, and by equality, oldest first):

WHERE vote_count >= 5
ORDER BY rating DESC, vote_count DESC, id ASC

Then (below 5 votes, same ordering):

WHERE vote_count < 5
ORDER BY rating DESC, vote_count DESC, id ASC
WHERE vote_count >= 15
ORDER BY rating DESC, vote_count DESC, id ASC

Rating is what JED calls the average score.

(column names here are just for the logic)

beat commented 10 years ago

PR with fix to the server part https://github.com/joomla-projects/joomla-cms/tree/feature-appstore-server welcome

emavro commented 10 years ago

Fixed with PR https://github.com/joomla-projects/joomla-cms/pull/244

ghost commented 10 years ago

Does that take into account the 15 vote minimum for the general top rated list?

emavro commented 10 years ago

No, but we don't have a link to the top rated list, anyway.

ghost commented 10 years ago

Yes you do: when 'Home' is selected and you 'Sort by Rating'.

emavro commented 10 years ago

But the top rated list appears by category on JED, doesn't it?

ghost commented 10 years ago

The categories are sorted by rating by default (first everything with 5 votes or more, then the rest).

But there is also a general Top Rated page: http://extensions.joomla.org/extensions/top-rated (See the 'DIRECTORY MENU' on the left, under the categories)

That Top Rated page only includes extensions that have 15 or more votes.

It would be most logical that the general list (when ordered by rating) is the same as the Top 100 top rated on the JED.

Another thing: the Home lists in the 'Install from Web' only show a limited number of listings (24). There is no pagination. So in the 'Home' view the 'Sort by Name' is useless.

And would it be better to show 100 listings instead of 24 in the Home lists? To match the general lists in the JED (Top Rated, Most Reviewed, New Extensions, Recently Updated).

emavro commented 10 years ago

So, to be in line with JED, the condition should be set to 15 or more votes when sorting by rating on home page but 5 votes or more under category view. That's pretty easy to implement but I just want to be sure we get the right thing done.

As far as the number of listings is concerned on the home page, we can check with the users and see what the optimal balance between the number of extensions that appear on the home page and actual loading time is. Remember! JED's actual home page only lists six "new and noteworthy" extensions and two random ones with logos and short info.

In any case, if you asked me as a user, I'd say that 100 extensions with their logos on the home page is a little too much.

ghost commented 10 years ago

but 5 votes or more under category view

No, under category view all are shown. See @beat's earlier post. And mine:

The categories are sorted by rating by default (first everything with 5 votes or more, then the rest).

So on Home (when 'Sort by Rating' is selected):

On categories:

emavro commented 10 years ago

Of course, everything is viewed under category view. I'm only commenting on sorting.

My PR updates the JEF server as you point out in your categories comment. I'll update dashboard view, too, to match your suggestion.

Thanks for your input and helping us straighten things out.

ghost commented 10 years ago

My pleasure.

PS: I agree, the whole sorting in the current JED is crazy! :)

porwig commented 10 years ago

JED and JEF are still getting to know each other, but I think they will become good friends :-)

On Wed, Nov 13, 2013 at 9:52 AM, Peter van Westen notifications@github.comwrote:

My pleasure.

PS: I agree, the whole sorting in the current JED is crazy! :)

— Reply to this email directly or view it on GitHubhttps://github.com/beat/tracker-apps/issues/27#issuecomment-28411564 .

ghost commented 10 years ago

If JEF can put up with the weird moods JED usually has, then yes. I predict JEF is secretly waiting for a younger and sexier JED to come along and will file divorce papers as soon as that happens.

deianmotov commented 10 years ago

Hello everyone and thank you for working on it!

I don't want to bring additional confusion to how the JED ordering works, but here are my thoughts, I will keep it short: Paid Downloads section

1 - QuickSell File Seller 32 votes 33 reviews 5/5 average

2 - Nice PayPal Downloads - 11 votes 33 reviews 5/5 average

Now on the long run I assume that my competitor had 33 or move votes with these 33 reviews, but they seem to expire (i'm pretty sure they do and according to me period is 2 years).

Since I have more recent 32 votes than him, who have for the same period 11, I'm placed first on JED, while I'm sure if they weren't expired he would have 33/33 5/5.

I hope that helps! I will work on it too!

Kindest regards, Deian Motov

beat commented 10 years ago

@nonumber LOL

@deianmotov Thanks for the example. It confirms the sorting that @nonumber explained me 2 days ago and that I outlined above. As we are looking at same fileds in same database as JED, we get the same counts. So all will be ok once the latest PR goes through QA review, QC testing and CDN deployment.

ghost commented 10 years ago

Correct, The ordering only looks at vote count, not at review count.

On Thursday, November 14, 2013, beat wrote:

@nonumber https://github.com/nonumber LOL

@deianmotov https://github.com/deianmotov Thanks for the example. It confirms the sorting that @nonumber https://github.com/nonumberexplained me 2 days ago and that I outlined above. As we are looking at same fileds in same database as JED, we get the same counts. So all will be ok once the latest PR goes through QA review, QC testing and CDN deployment.

— Reply to this email directly or view it on GitHubhttps://github.com/beat/tracker-apps/issues/27#issuecomment-28464122 .

Bakual commented 10 years ago

Actually we should remove the "Sort by Popularity" alltogether and make "Sort by Rating" the default order instead. Assuming that "Popularity" means "Pageviews" it's highly in favor of old extensions and basically makes it impossible for newer (and maybe even better) extensions to get to the top. Those already on top will always get more pageviews anyway.

beat commented 10 years ago

Closing this one as its subject has now been fixed and propagated.

For the other popularity-default issue, opened this new tracker here: https://github.com/beat/tracker-apps/issues/28

ghost commented 10 years ago

Yes, sorting has been fixed :)

What about @Bakual's comment?

Actually we should remove the "Sort by Popularity" alltogether and make "Sort by Rating" the default order instead. Assuming that "Popularity" means "Pageviews" it's highly in favor of old extensions and basically makes it impossible for newer (and maybe even better) extensions to get to the top. Those already on top will always get more pageviews anyway.

Bakual commented 10 years ago

@nonumber I think that's why @beat openend the new issue https://github.com/beat/tracker-apps/issues/28 ;)

beat commented 10 years ago

Yes :)

And we will be starting implementing these adjustments in next days, which gives a day or 2 for feedbacks from all teams and community.

ghost commented 10 years ago

Ok, great :)

deianmotov commented 10 years ago

Main categories via popularity sub categories via rating, looks good I think!

On 21.11.2013, at 18:25, Peter van Westen notifications@github.com wrote:

Ok, great :)

— Reply to this email directly or view it on GitHub.