search

beatfreaker / text-meme

Generate text meme
MIT License
9 stars 1 forks source link

Make the default image larger #1

Open sindresorhus opened 8 years ago

sindresorhus commented 8 years ago

A lot of people have high resolution (retina) screens and default size becomes very small when use make it use half the width (to get double the resolution).

Like here: https://github.com/beatfreaker/text-meme-cli/pull/1#discussion_r48091644

beatfreaker commented 8 years ago

@sindresorhus so the default size should be 160 right?

sindresorhus commented 8 years ago

No, the double of the size you want to use as it needs to be shrunk by the img tag to half to the size to be retina. So if you want it to be 160px it needs to be outputted in 320px. I think 300px would be a good size, so it needs to be outputted with 600px.

beatfreaker commented 8 years ago

changes default image size from 320 to 600 check here @sindresorhus can you please review it once?

sindresorhus commented 8 years ago

Looks good, but you should also document the default size in this readme and in the CLI readme.