beatmasterRS / skin.arctic.zephyr.mod

Welcome to Arctic: Zephyr - Reloaded. A clean, minimal, elegant, simple, light skin, based on the original Arctic: Zephyr skin by jurialmunkey.
Other
164 stars 60 forks source link

[Bug] the previous fanart is displayed in addition to the default fanart with stream radio #362

Closed Nanomani closed 3 years ago

Nanomani commented 3 years ago

the previous fanart is displayed in addition to the default fanart with stream radio :

reproduce :

expected :

screenshot00014

don't worry it is for myseft :D but all help are welcome :)

Nanomani commented 3 years ago

reverse problem with music o_O

screenshot00015

beatmasterRS commented 3 years ago

https://github.com/beatmasterRS/skin.arctic.zephyr.mod/blob/ad2bc2e547c26dbbdbaa1059c15c5f51770c764b/1080i/MusicVisualisation.xml#L14-L22

especially line

https://github.com/beatmasterRS/skin.arctic.zephyr.mod/blob/ad2bc2e547c26dbbdbaa1059c15c5f51770c764b/1080i/MusicVisualisation.xml#L18

Was the image only a fallback? then something like:

<visible>!String.IsEmpty(Skin.String(fanart.fallback.music)) + [[Skin.HasSetting(musicvis.fanartfallback) + String.IsEmpty(Player.Art(fanart))] | [!Skin.HasSetting(ArtistSlideShow.Disabled) + String.IsEmpty(Window(Visualisation).Property(ArtistSlideshow.Image))]]</visible>

could be helpfull. Untested ^^

Nanomani commented 3 years ago

Was the image only a fallback? then something like:

<visible>!String.IsEmpty(Skin.String(fanart.fallback.music)) + [[Skin.HasSetting(musicvis.fanartfallback) + String.IsEmpty(Player.Art(fanart))] | [!Skin.HasSetting(ArtistSlideShow.Disabled) + String.IsEmpty(Window(Visualisation).Property(ArtistSlideshow.Image))]]</visible>

could be helpfull. Untested ^^

I have post a PR :)

But I will keep your proposal carefully :D

Anyway it is much better now :

with stream radio fallback backgroung is used:

screenshot00016

with music if there is fanart on local or with artist slideshow otherway fallback backgroung is used

screenshot00017