search

beatmasterRS / skin.arctic.zephyr.mod

Welcome to Arctic: Zephyr - Reloaded. A clean, minimal, elegant, simple, light skin, based on the original Arctic: Zephyr skin by jurialmunkey.
Other
164 stars 60 forks source link

TV series Indicator Problem #936

Closed semool closed 1 year ago

semool commented 1 year ago

Something is wrong with this commit: https://github.com/beatmasterRS/skin.arctic.zephyr.mod/commit/773fb4ebf4181c6d38688cefabe0c141d44586f7

I have selected only New and watched in the Indicator config. This works fine before the commit. Now i have the indicator running circle on every started TV Show and it replaced the new episodes indicator (flame)

beatmasterRS commented 1 year ago

I tried to change that. But I have a question of understanding. If I have a TV show that includes new eposides and some episodes are watched, I want to see the flame and not the in progress icon or? That means the flame always has priority, right?

beatmasterRS commented 1 year ago

Within the current PR, for me it seems to be fine.

screenshot01346

What do you think?

beatmasterRS commented 1 year ago

One more question: if I only have "New" and "Watched" enabled, no round circle would appear on "Marvel's Daredevil" as you can see on my screenshot (since in-progress is not enabled). Would it make sense to still show the round circle as a fallback in the list view to prevent empty fields? So that if I disable all options, I still get a round circle for all entries? Just a thought

semool commented 1 year ago

If I have a TV show that includes new eposides and some episodes are watched, I want to see the flame and not the in progress icon or? That means the flame always has priority, right?

Yes i think that is the only logical Solution.

Would it make sense to still show the round circle as a fallback in the list view to prevent empty fields? So that if I disable all options, I still get a round circle for all entries? Just a thought

No. Example: Myself i use a Widget in the Homescreen for Started Series. It displayed the Posters of my started Series. In the Widgets the status Icons would display as a Overlay in the Posters. I dont want any Overlays on this Posters (except the New flame), i know this was a running series :)

i will try the PR version now.

Edit: Works fine with the PR. Thank you :)

beatmasterRS commented 1 year ago

Okay thank you, then i will merge the pr :)