beatonma / django-wm

Automatic Webmention functionality for Django models
https://beatonma.org/webmentions_tester/
GNU General Public License v3.0
12 stars 2 forks source link

Single incoming webmention repeatedly being processed. #43

Closed garrettc closed 1 year ago

garrettc commented 1 year ago

Hi,

I'm seeing a bug where a webmention is being continuously processed and keeps adding entries to the Webmentions page in admin (my cron job runs at 45 minutes past every hour).

Screenshot 2022-10-24 at 09 06 21

Each entry has the note:

Unable to find matching page on our server for url 'https://polytechnic.co.uk/blog/2022/03/site-update/'

Which is a separate issue at my end in trying to get django-wm to play with Wagtail, I have other incoming webmentions that fail to find the post, but aren't repeating like this.

There's nothing outstanding in the "Pending incoming webmentions" screen.

I've spoken with @philgyford (the source of the webmention) and he doesn't see anything strange at his end.

Any ideas on how to diagnose this? Happy to give you a database snapshot if needed.

python 3.7.3 Django 3.2.14 django-wm 3.1.0

philgyford commented 1 year ago

Fwiw, these are the only references to that post in my Outgoing Webmentions.

209CA1A0-4272-444E-9DD9-79D1B93CDBAD

I have no Pending Outgoing Contents.

beatonma commented 1 year ago

Curious - I'm getting something very similar.

Screenshot from 2022-10-24 18-23-16

Thank you both - I'll look into it and get back to you asap!

beatonma commented 1 year ago

3.1.1 is now available and should fix this.

There was a bug when retrying a failed webmention. One instance of OutgoingWebmentionStatus could trigger a retry, but a different instance could be used to track the progress of that retry. The trigger was never updated with the results so it triggered again the next time.

@philgyford please let me know once you get a chance to update so we can verify that this was the cause.

They should retry once more, and potentially a few more times (depending on settings.WEBMENTIONS_MAX_RETRIES, default 5) if there are network errors.

Thanks again and sorry for the inconvenience.

philgyford commented 1 year ago

Hi - my site's updated to 3.1.1 now.

beatonma commented 1 year ago

Great, thanks - looks good from here!

@garrettc are you still receiving duplicates?

garrettc commented 1 year ago

Looks good here. I haven’t received any duplicates since 2:45pm 👍