search

beatrichartz / exchange

Easy Currency Operations directly available on your numbers - maintenance discontinued
http://beatrichartz.github.com/exchange
MIT License
42 stars 22 forks source link

Updated country map to the latest country-currency mapping #17

Closed ridem closed 9 years ago

ridem commented 9 years ago

I was having some issues with getting a price for Lithuania and Latvia (throwing exceptions) , and then I realized they actually had a different currency than the one in the iso country map. So I updated this list to the latest definition. Here's the gist of the script made to generate the yaml file.

https://gist.github.com/ridem/80697bed0580589ea424

The problem was to get the right official currency when a country has several ISO 4217 currencies. The gist is displaying the countries that need to be double-checked

beatrichartz commented 9 years ago

Hi there! Thanks for the work, I'd love to be able to merge this, however the tests are failing with the given change. Please let me know when you get them passing so I can have another look.

ridem commented 9 years ago

Yeah sorry, I forgot to add the new def in your specs. This one is passing the tests ;)

beatrichartz commented 9 years ago

Thanks!