Fix checking of supported currency

beatrichartz / exchange

Easy Currency Operations directly available on your numbers - maintenance discontinued

http://beatrichartz.github.com/exchange

MIT License

42 stars 22 forks source link

Fix checking of supported currency #3

Closed smostovoy closed 11 years ago

smostovoy commented 11 years ago

We had errors like "Exchange::NoRateError: No rates where found for to 1.3044 at 2013-07-12 20:02:05 +0000'" The problem was in converting unsupported currency to supported, e.g. INR to USD. INR is supported by ECB and fallback didn't work

beatrichartz commented 11 years ago

Thanks for your work & reporting the problem!

Could you add a spec failing without your code and passing with it so I can merge this in?

smostovoy commented 11 years ago

ok, will do on a weekend

smostovoy commented 11 years ago

done

beatrichartz commented 11 years ago

Ok, new release is 1.1.0 since I had also to deprecate 1.8.7 support. Thanks for your work!

smostovoy commented 11 years ago

will you merge it?

beatrichartz commented 11 years ago

Already merged it, it is in the new release. See master for details.