search

beatrixparis / connectivity-modeling-system

The CMS is a multiscale stochastic Lagrangian framework developed by Paris' Lab at the Rosenstiel School of Marine, Atmospheric & Earth Science to study complex behaviors, giving probabilistic estimates of dispersion, connectivity, fate of pollutants, and other Lagrangian phenomena. This repository facilitates community contributions to CMS modules
https://beatrixparis.github.io/connectivity-modeling-system/
GNU General Public License v3.0
31 stars 25 forks source link

Fixed bugs + some other improvements #49

Closed jvdp1 closed 4 months ago

jvdp1 commented 5 months ago

Here are some proposals for fixing bugs and improvements. Each commit should be independent, and so enabling cherry-picking

milancurcic commented 5 months ago

Thanks @jvdp1 for these changes, I think they're overall good changes. I'll discuss with @beatrixparis on how to get more organized with reviewing and merging PRs (I don't have merge privilege yet).

beatrixparis commented 5 months ago

Thanks Milan. I approved the changes. Let’s discuss how to give you rights on CMS when we meet this Wednesday.

Claire B. Paris Sent from iPhone - apologies for typos

Le 30 mai 2024 à 16:00, Milan Curcic @.***> a écrit :

Thanks @jvdp1https://urldefense.com/v3/__https://github.com/jvdp1__;!!KVu0SnhVq1hAFvslES2Y!OgumbYjIQKnoxDFx5KyflTr_AZ5nzjE4ThaOtchZK5kX1YKaaCuo3g1EOXHyXWgVM4T1kotLQN7AoH15qrRICHKpOA56$ for these changes, I think they're overall good changes

milancurcic commented 5 months ago

Hi Claire, you closed this PR without merging it, so the changes are not applied. I don't think you meant to do that. If you want to merge these changes into the master branch, there should be a button here at the bottom that says "Re-open" (or similar), and then there will be a green button that says "Merge pull request" (or similar).

beatrixparis commented 5 months ago

Hello Milan, Can we meet this afternoon and do it together? Claire B. Paris Sent from iPhone - apologies for typos

Le 31 mai 2024 à 07:48, Milan Curcic @.***> a écrit :

 CAUTION: This email originated from outside the organization. DO NOT CLICK ON LINKS or OPEN ATTACHMENTS unless you know and trust the sender.

Hi Claire, you closed this PR without merging it, so the changes are not applied. I don't think you meant to do that. If you want to merge these changes into the master branch, there should be a button here at the bottom that says "Re-open" (or similar), and then there will be a green button that says "Merge pull request" (or similar).

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/beatrixparis/connectivity-modeling-system/pull/49*issuecomment-2141873926__;Iw!!KVu0SnhVq1hAFvslES2Y!MQs957jsuaAD5El_M6MmFbxUA5eHRa0S9xUbec0xxtIYCUsqgCPlqldLxr2bM_PdWetg_76LaxesMuS8HJNBVeHwFfrl$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACZ27ZEDARWERL5TUIYKBLTZFBPRRAVCNFSM6AAAAABINKI4HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRHA3TGOJSGY__;!!KVu0SnhVq1hAFvslES2Y!MQs957jsuaAD5El_M6MmFbxUA5eHRa0S9xUbec0xxtIYCUsqgCPlqldLxr2bM_PdWetg_76LaxesMuS8HJNBVdvg3ex9$. You are receiving this because you modified the open/close state.Message ID: @.***>