search

beatsabertools / sabergen

Beat Saber song generator
GNU General Public License v3.0
3 stars 0 forks source link

Restructure lib/cli relationship #11

Closed ryanwersal closed 6 years ago

ryanwersal commented 6 years ago

This change moves more of the concerns into the library (it seems better to have the library enforce the ogg format requirement than have all callers mandate it). It still leaves the same public API surface in case the caller does want to change the behavior but load now handles the main concern (only ogg format past a certain point).

Also add more details to the wiki for getting ffmpeg successfully installed with the necessary codecs etc. It is probably we will need to add more in the future (the ones included are the ones I needed to successfully convert an mp3 I was testing with).

ryanwersal commented 6 years ago

FYI @zvekovius I'm going to land this as is and create a new branch/PR with a pylint config file (and probably update the Azure build as well) based on what we discussed here.