beatsabertools / sabergen

Beat Saber song generator
GNU General Public License v3.0
3 stars 0 forks source link

Figure out way to create cover art image from ogg file #16

Closed ryanwersal closed 6 years ago

ryanwersal commented 6 years ago

Mutagen doesn't appear to "see" the cover art anymore. However, other tools "see" cover art within it so it would be ideal to somehow get the cover art and generate the appropriate file if it exists.

I'm thinking we should just fail the conversion process entirely if we aren't able to generate any of the constituent files. This likely also will involve adding a flag for the user to provide a cover art image themselves if one isn't in the file format itself.

ryanwersal commented 6 years ago

Looks like it might be possible to get it from "Vorbis comments": https://mutagen.readthedocs.io/en/latest/user/vcomment.html

ryanwersal commented 6 years ago

This also seems incredibly useful for seeing what's all in specific ogg files: https://mutagen.readthedocs.io/en/latest/man/mutagen-inspect.html

ryanwersal commented 6 years ago

Well, interestingly, ffmpeg doesn't support cover art in ogg files due to this bug. It currently treats input covert art images as theora encoded videos. That explains why mutagen can't read it.