search

beatsabertools / sabergen

Beat Saber song generator
GNU General Public License v3.0
3 stars 0 forks source link

Add cover art support to ogg conversion and output #17

Closed ryanwersal closed 6 years ago

ryanwersal commented 6 years ago

This ended up being an interesting journey - ffmpeg has an open bug about how it doesn't support conventional cover art. It instead uses theora to encode the cover as a video stream embedded in the ogg file. This both bloats the ogg file and isn't very useful. I found a few sources within mutagen's documentation that seemed to paint a hopeful picture of writing it into a conventional location. While this was successful for purposes of pulling the art back out of the ogg for final writing to the destination directory I haven't yet seen the cover art picked up directly from the ogg by applications I've tried. However, that isn't really the objective so it seems fine to leave for now.

This should close #16

ryanwersal commented 6 years ago

Adding the WIP label as I just found out that the APIC frames are declared pretty uniquely across even MP3s so I'm adding better handing of that.

ryanwersal commented 6 years ago

Ready for review! It now works with more than a single file!