search

beatsabertools / sabergen

Beat Saber song generator
GNU General Public License v3.0
3 stars 0 forks source link

Fail build on pylint errors #18

Closed ryanwersal closed 6 years ago

ryanwersal commented 6 years ago

While working on #17 I noticed that I had accidentally introduced an actual pylint error and not noticed - particularly since the build stayed green. This was due to the || true I added to the script as originally it would fail the build if any message was reported (and since everything is enabled that is a lot).

I dug in more and found that we can have it only check for errors on the build which seems better (only fails the build on error) but also less good if we were to actively check the output for things we can do better on (but aren't specifically errors).

ryanwersal commented 6 years ago

I should add that it is actually desirable for the CI build on this PR to fail as it should due to the issue I committed already being on master. #17 has the fix for it and this will ensure that the build fails when it should.