search

beauby / jsonapi-datastore

JavaScript client-side JSON API data handling made easy.
MIT License
195 stars 40 forks source link

Fix duplicate attributes issue #18

Closed amwmedia closed 7 years ago

amwmedia commented 8 years ago

fixed an issue where a record that is see twice, ends up with an _attributes array that has all values duplicated

beauby commented 8 years ago

Hi @amwmedia, thanks a lot for the fix. Would you mind adding a test case?

amwmedia commented 8 years ago

no problem. I've really enjoyed working with your library. If brings a lot of usefulness without trying to do too much. :+1:

beauby commented 8 years ago

Sorry I took so long to review this. Please see my last comment. Apart from that, it looks ready to be merged!

amozoss commented 8 years ago

Would be neat if this was merged. Seems like it just needs a one line change or something. @amwmedia

beauby commented 8 years ago

Sorry, I've been a bit busy with other stuff lately but plan to take care of this one tomorrow.

On Saturday, 23 April 2016, Dan Willoughby notifications@github.com wrote:

Would be neat if this was merged. Seems like it just needs a one line change or something. @amwmedia https://github.com/amwmedia

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/beauby/jsonapi-datastore/pull/18#issuecomment-213787395

Lucas Hosseini lucas.hosseini@gmail.com

amwmedia commented 8 years ago

@amozoss yeah, there's really not a lot to do on this, I just haven't had ANY time. We are approaching an MVP release at work... and all that entails. once we get past this release, I'll have some time to contribute more. I'll button this up then if it's not been taken care of by someone else at that point.

anlek commented 8 years ago

Any news on this?

beauby commented 7 years ago

Hey @amwmedia – any news on this one?

amwmedia commented 7 years ago

this should be ready now, sorry for all the delays. We had a major MVP going out on a tight deadline so everything else took a backseat.

anlek commented 7 years ago

@amwmedia Hope your MVP went well. I was just wondering if there is any chance of this patch being released via NPM?

amwmedia commented 7 years ago

This is ready to be merged. @beauby can you accept the PR? :-)

beauby commented 7 years ago

Merging – thanks for your work @amwmedia!

anlek commented 7 years ago

That's awesome, thank you for merging. Any chance we can see this be released via NPM sometime soon?