search

beauby / jsonapi-datastore

JavaScript client-side JSON API data handling made easy.
MIT License
195 stars 40 forks source link

Convert to ES6 #8

Closed jprincipe closed 8 years ago

jprincipe commented 8 years ago

@beauby resolved the merge issues form the last PR

jprincipe commented 8 years ago

@beauby I have another PR coming based off of ES6 to add support for meta data. After you accept this PR I'll submit the next one.

beauby commented 8 years ago

@jprincipe Thanks for the rebase (for future reference, you can git rebase and git push -f for squashing so that you don't have to create a new PR). Is there a technical reason why you merged store.js and model.js into a single file?

jprincipe commented 8 years ago

It was to avoid an issue that babel was having with store.js referencing model.js. The minified version of the file didn't know what to do with the reference because after minification model.js doesn't exist.

beauby commented 8 years ago

@jprincipe Sorry it took so long, I've been really busy with ActiveModel::Serializers lately. One last question before merge: does this PR play nice with the angular wrapper?

jprincipe commented 8 years ago

I haven't tested the angular wrapper specifically, but all the code is converted from es6 before so there should be no issues

beauby commented 8 years ago

Ok great, merging then. Thanks a lot!