beaufortfrancois / sandbox

:baby_chick:
MIT License
71 stars 32 forks source link

Fix display issues with special HTML characters #13

Closed mmocny closed 7 years ago

mmocny commented 7 years ago

If the resolved_url (or other fields) contain strings like "&lt", they will be replaced with "<" in HTML and cannot be copy-pasted correctly. We should escape these strings.

For the record, this patch is untested! I did test the HtmlEncode helper I borrowed.

mmocny commented 7 years ago

Francois, any idea if its possible to test this by rendering a github page from the PR? Perhaps I can use my branch as the base of the github page URL?

beaufortfrancois commented 7 years ago

Thanks for the bug report @mmocny! I've fixed this in https://github.com/beaufortfrancois/sandbox/commit/34eb9c2dd14d92b2a3122e98f438ec8a39d959dc