search

beaufortfrancois / sandbox

:baby_chick:
MIT License
72 stars 32 forks source link

Update Remote Playback API demo for compatibility with WebKit #16

Closed markafoltz closed 6 years ago

markafoltz commented 6 years ago

This updates the Remote Playback API demo for compatibility with the currently shipped WebKit API:

https://developer.apple.com/documentation/webkitjs/adding_an_airplay_button_to_your_safari_media_controls

This is mostly to understand the current behavior of the API. If you don't want to include WebKit support in this demo, I can put it in a separate file or keep it in my repo.

I also changed the video timestamp to start at the beginning since there are only about 20 seconds left otherwise.

CC @mounirlamouri

beaufortfrancois commented 6 years ago

Thank you @mfoltzgoogle! I've merged it at https://github.com/beaufortfrancois/sandbox/pull/17

beaufortfrancois commented 6 years ago

I've fixed nits at https://github.com/beaufortfrancois/sandbox/commit/f06d09d9c1873e126736834d29b8b963ea9059ef

beaufortfrancois commented 6 years ago

And here's what I get. Is that expected? bs_machs_safari_11 0

beaufortfrancois commented 6 years ago

@mfoltzgoogle (gentle ping)

markafoltz commented 6 years ago

Is this on iOS without an AirPlay device? Then that looks correct.