search

beaufortfrancois / spotify-hotkeys-chrome-extension

Spotify Web Player Hotkeys Chrome Extension
https://chrome.google.com/webstore/detail/kimlaecdbfehihbiieeaeelbdkahophn
95 stars 31 forks source link

updated for new spotify layout #1

Closed marcosimone closed 7 years ago

marcosimone commented 9 years ago

hey, I updated the extension for the new spotify layout they are rolling out.

beaufortfrancois commented 9 years ago

Thanks Marco for this. However I cannot see the new https://player.spotify.com as it always redirects me to the "old" https://play.spotify.com. Any reason why you might be aware of?

marcosimone commented 9 years ago

I'm not sure why that happens, my roommate gets redirected to play.spotify, but I get redirected to player. Maybe you can add code to check for either play or player and use the correct html pattern accordingly. On May 26, 2015 1:35 AM, "François Beaufort" notifications@github.com wrote:

Thanks Marco for this. However I cannot see the new https://player.spotify.com as it always redirects me to the "old" https://play.spotify.com. Any reason why you might be aware of?

— Reply to this email directly or view it on GitHub https://github.com/beaufortfrancois/spotify-hotkeys-chrome-extension/pull/1#issuecomment-105445382 .

marcosimone commented 9 years ago

Hey, I added support for both play and player, and in the process I actually learned a lot about making chrome extensions (this was my first attempt at it). I just wanted to ask you if you're ok with me continuing this branch and possible add more stuff to the extension and publishing my own version of the extension with features I add. I would mention that I originally forked it from you're project as well.

--Marco Simone

--Marco Simone

On Tue, May 26, 2015 at 1:46 AM, Marco Simone marco.j.simone@gmail.com wrote:

I'm not sure why that happens, my roommate gets redirected to play.spotify, but I get redirected to player. Maybe you can add code to check for either play or player and use the correct html pattern accordingly. On May 26, 2015 1:35 AM, "François Beaufort" notifications@github.com wrote:

Thanks Marco for this. However I cannot see the new https://player.spotify.com as it always redirects me to the "old" https://play.spotify.com. Any reason why you might be aware of?

— Reply to this email directly or view it on GitHub https://github.com/beaufortfrancois/spotify-hotkeys-chrome-extension/pull/1#issuecomment-105445382 .

beaufortfrancois commented 9 years ago

Please do so Marco! I'm happy you've created your own version and played with Chrome Extensions.

beaufortfrancois commented 7 years ago

I've just pushed https://github.com/beaufortfrancois/spotify-hotkeys-chrome-extension/commit/a372fc50eb2e283c0a31d30a869feb46332a159d to support https://open.spotify.com web player. Check out new version at https://chrome.google.com/webstore/detail/spotify-web-player-hotkey/kimlaecdbfehihbiieeaeelbdkahophn and let me know if that works out for you ;)