beaufortfrancois / spotify-hotkeys-chrome-extension

Spotify Web Player Hotkeys Chrome Extension
https://chrome.google.com/webstore/detail/kimlaecdbfehihbiieeaeelbdkahophn
95 stars 31 forks source link

Updated to work with Spotify's new javascript web player #10

Closed ehutzelman closed 7 years ago

ehutzelman commented 7 years ago

This allows the extension to work with Spotify's new open.spotify.com javascript player. I assume this will be the default player for everyone in the near future if it is not already.

This PR does break backward compatibility with the old flash-based web player.

beaufortfrancois commented 7 years ago

Thanks @ehutzelman for this PR. It seems like https://open.spotify.com/ is not the default page by default though for everyone. It still redirects to https://play.spotify.com/... when playing a song when flash is enabled.

We might want to keep compatibility for both.

beaufortfrancois commented 7 years ago

I've just pushed https://github.com/beaufortfrancois/spotify-hotkeys-chrome-extension/commit/a372fc50eb2e283c0a31d30a869feb46332a159d to support https://open.spotify.com web player. Check out new version at https://chrome.google.com/webstore/detail/spotify-web-player-hotkey/kimlaecdbfehihbiieeaeelbdkahophn and let me know if that works out for you ;)

ehutzelman commented 7 years ago

Thanks, I tried it out and it works except for play/pause button. I left a comment on the commit: https://github.com/beaufortfrancois/spotify-hotkeys-chrome-extension/commit/a372fc50eb2e283c0a31d30a869feb46332a159d

beaufortfrancois commented 7 years ago

I've just fixed that in https://github.com/beaufortfrancois/spotify-hotkeys-chrome-extension/commit/c06f8ac765042945c32eff2ed2ac1ba2a054c370 and pushed an update to https://chrome.google.com/webstore/detail/kimlaecdbfehihbiieeaeelbdkahophn

ehutzelman commented 7 years ago

Works great now, thanks.