search

beaufour / flickr-download

Tool for downloading sets and photos from Flickr
Apache License 2.0
231 stars 65 forks source link

Allow to use profile URL or email instead of username #43

Closed astanin closed 5 years ago

astanin commented 6 years ago

It appears that some users cannot be found by findByUserName(); API returns error code 1. Such users can still be referenced by their email or URL.

Proposed change: use findByEmail and findByUrl methods instead of findByUserName if the given username appears to be an email (contains @) or a URL (starts with https://, www.flickr.com, or flickr.com.).

Potential issues: users having @ in their username may have to use URL of their profile instead.

P.S. This is the same as the closed pull request #40, but now from a feature branch.

beaufour commented 6 years ago

Ugh, I totally missed #40. Sorry about that!

Thanks for the PR. It looks good. Could you give me some examples of a user or two that doesn't work in the current version?

astanin commented 6 years ago

An example of the profile where username doesn't work: https://www.flickr.com/people/srg0/

softyoda commented 1 year ago

Thanks for this modification, It would be nice if this information is also mentioned in the readme tuto

beaufour commented 1 year ago

Good idea @softyoda ! Just added that.