search

beaugunderson / django-gulp

🔧 override runserver and collecstatic to run gulp tasks
https://pypi.python.org/pypi/django-gulp
MIT License
89 stars 15 forks source link

Fail collectstatic if gulp fails #6

Closed joshblum closed 8 years ago

joshblum commented 8 years ago

It would be helpful if the gulp process fails that the collectstatic command also fails. Right now the exit code is unused at https://github.com/beaugunderson/django-gulp/blob/master/django_gulp/management/commands/collectstatic.py#L36 so it should be simple to fail the command here. I can submit a PR if you think this will be useful! Let me know :)

beaugunderson commented 8 years ago

sounds great, will happily merge a PR for that, thank you!

Sent from my phone.

On Jun 28, 2016, at 16:01, Joshua Blum notifications@github.com wrote:

It would be helpful if the gulp process fails that the collectstatic command also fails. Right now the exit code is unused at https://github.com/beaugunderson/django-gulp/blob/master/django_gulp/management/commands/collectstatic.py#L36 so it should be simple to fail the command here. I can submit a PR if you think this will be useful! Let me know :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

joshblum commented 8 years ago

Great! If the PR ( #7 ) looks ok, could you update the pypi version? It would be great if I could use this fix in my code asap. Thanks!!

beaugunderson commented 8 years ago

merged #7 and released as 2.4.1, thanks again!

joshblum commented 8 years ago

Thank you so much for the speedy responses!!