beaugunderson / ip-address

💻 a library for parsing and manipulating IPv4 and IPv6 addresses in JavaScript
http://ip-address.js.org/
MIT License
582 stars 73 forks source link

Replace `jsbn` with native BigInt #174

Closed michal-kocarek closed 1 month ago

michal-kocarek commented 1 month ago

This PR follows up on #173 and fixes #169 for good by switching from jsbn BigInteger instance to native BigInt.

This PR introduces breaking changes:

If you find this valuable, it might need:

Let me know, @beaugunderson what you think about this PR.

beaugunderson commented 1 month ago

this is fantastic work, thanks! much simpler than I thought it would be too, wow

will work on getting this in and released soon 🙏

beaugunderson commented 1 month ago

gonna merge this, then add one additional change (rename references to BigInteger to BigInt for clarity)

michal-kocarek commented 1 month ago

Thank you, @beaugunderson. I was unsure how you want to deal with breaking change in the API interface.

Thank you for merging this quickly.

I hope that it didn't introduce any regression. Will be looking forward for a new release of this library :)