search

beaugunderson / ip-address

💻 a library for parsing and manipulating IPv4 and IPv6 addresses in JavaScript
http://ip-address.js.org/
MIT License
525 stars 71 forks source link

add non-string check #99

Closed drahnieR closed 12 months ago

codecov-io commented 4 years ago

Codecov Report

Merging #99 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #99   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         623    632    +9     
  Branches       94     96    +2     
=====================================
+ Hits          623    632    +9
Impacted Files Coverage Δ
lib/ipv6.js 100% <100%> (ø) :arrow_up:
lib/ipv4.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2279707...7ef42fa. Read the comment docs.

drahnieR commented 4 years ago

@beaugunderson how's your opinion on this

beaugunderson commented 4 years ago

@drahnieR i like this; can you change the error message to note that the argument should be a string?

drahnieR commented 4 years ago

@beaugunderson done

drahnieR commented 4 years ago

@beaugunderson any chance that this could be released soon?

beaugunderson commented 12 months ago

we migrated away from lodash but this would still be useful if implemented in vanilla JS