beaugunderson / vscode-solidity-extended

✏ Solidity support for VSCode
https://marketplace.visualstudio.com/items?itemName=beaugunderson.solidity-extended
Other
10 stars 9 forks source link

Support for Solium v1 #3

Open Alonski opened 6 years ago

Alonski commented 6 years ago

Currently this extension only works with Solium v0.x Getting an error using new Solium format.

roderik commented 6 years ago

Quick fix, upgrade deps manually in ~/.vscode

Alonski commented 6 years ago

What to you mean exactly?

roderik commented 6 years ago

This mostly works for me:

cd ~/.vscode/extensions/beaugunderson.solidity-extended-3.0.2/
# update the version numbers in package.json
npm i
# restart vscode
beaugunderson commented 6 years ago

this extension will use the version of solium you have installed locally in your project's node_modules directory, so if you have solium 1.x installed in your project it should work with the new config format

@Alonski can you try that and verify if it works?

i will also update the extension to use 1.x by default

roderik commented 6 years ago

@beaugunderson I had errors as well, will try again and return with more info if it reappears

roderik commented 6 years ago

On a clean version, it does the following;

https://www.dropbox.com/s/kzz94dukxityhkw/Screenshot%202017-11-17%2015.22.38.png?dl=0

config is:

{
  "extends": "solium:all",
  "plugins": ["security"],
  "rules": {
    "quotes": ["error", "double"],
    "indentation": ["error", 2],
    "no-empty-blocks": "off",
    "operator-whitespace": "warning",
    "security/enforce-explicit-visibility": ["error"],
    "security/no-block-members": "off"
  }
}
roderik commented 6 years ago

I found the issue, but I know next to nothing about extensions, so no fix

I'm working in a multi root application.

The extension is looking for solium in the first root, while i open a contract in the second root.