Closed marekhrabe closed 2 years ago
Strava was completely ignoring the value from the status dropdown and so everything used the default, publish status.
publish
I've updated it to do the same as other services — validate and store $_POST['status'] in handle_request_options, as introduced in https://github.com/beaulebens/keyring-social-importers/commit/a8c0ea12d98dbf7984983dd983df0690d6724781.
$_POST['status']
handle_request_options
The post saving logic was already counting with the option so we should be all good there. Additionally, #33 seems to no longer be an issue. Keyring uses the right scope (https://github.com/beaulebens/keyring/commit/4a0f839c72c866502c9a0a121c32e2eaaf8abc8f) and the handling of the private property from Strava API is also in place:
private
https://github.com/beaulebens/keyring-social-importers/blob/6e2ec5d2dd067747e4051d10afacdc6729769ad1/importers/keyring-importer-strava.php#L250-L254
I've removed the comment to reflect that.
Strava was completely ignoring the value from the status dropdown and so everything used the default,
publish
status.I've updated it to do the same as other services — validate and store
$_POST['status']
inhandle_request_options
, as introduced in https://github.com/beaulebens/keyring-social-importers/commit/a8c0ea12d98dbf7984983dd983df0690d6724781.The post saving logic was already counting with the option so we should be all good there. Additionally, #33 seems to no longer be an issue. Keyring uses the right scope (https://github.com/beaulebens/keyring/commit/4a0f839c72c866502c9a0a121c32e2eaaf8abc8f) and the handling of the
private
property from Strava API is also in place:https://github.com/beaulebens/keyring-social-importers/blob/6e2ec5d2dd067747e4051d10afacdc6729769ad1/importers/keyring-importer-strava.php#L250-L254
I've removed the comment to reflect that.