beaussan / update-time-on-edit-obsidian

MIT License
165 stars 15 forks source link

Creation date gets changed. #41

Closed Inclement9 closed 1 year ago

Inclement9 commented 1 year ago

Compare the file creation dates on these two screenshots. The created date should be the same on both.

Windows file properties box for this file:

image

Obsidian metadata:

image
profucius commented 1 year ago

@beaussan @bencodezen @heitor57 apologies but this plugin seems to be dead and we need some attention to this MAJOR bug.

Not sure which Obsidian version this started happening, but on 1.1.9, this plugin changes the create date every time it changes the updated time, and in my instance it seems to be changing the date to the past. One file example, you can see in the screenshot below, top to bottom is sequential for updated time, but created time goes backwards.

majorbug

I must disable this plugin until the issue is resolved. It has terribly destroyed the validity of all my file dates, which will be a massive headache to find a solution for, if I even can.

Inclement9 commented 1 year ago

In this issue post, Mrienstra quotes a suggestion from another message that people use the Linter plugin instead.

I've done that - uninstalled this one, installed Linter - and Linter seems to be adding the dates perfectly, as best I can tell in 24 hours.

If you're not already familiar with Linter (I wasn't), it's a much bigger plugin with many, many features. Make sure to go through and double-check that anything you don't want is turned off. Most things seem to be off by default - opt-in, not opt-out - but it can change your files so it's worth checking.

If Linter doesn't generate the created/modified frontmatter automatically, you can trigger it manually by "saving" with Ctrl-S. That works. (I'm too new to it to understand the whys and wherefores.)

Inclement9 commented 1 year ago

Oh - @profucius - in Settings > Core Plugins, do you have File Recovery turned on? That might help you. (I'm not very familiar with it, either.)

profucius commented 1 year ago

Wellll, I did have File Recovery turned on at one point, but disabled it due to using Syncthing to sync my vault to my android obsidian app. It comes with its own versioning, so I was relying on it instead, but then I just noticed that this bug caused Syncthing to go haywire and create hundreds of sync-conflict versions, all with either the same content and only the frontmatter dates changed, or sometimes with the content also changed (due to editing the file on my phone). Its a file-versioning nightmare that unfortunately I don't have the time to untangle. The good news at the very least is that I don't edit on my phone very much, so I will just fall back to a previous vault backup, and restore a few files.

Linter looks interesting, thanks for mentioning that! I'll be giving it a try after I get my vault stable again (and another backup!)

Let this thread be a cautionary tale to any who may come across this. Unfortunately unless the author @beaussan updates the Readme.md landing page with a warning, more people will probably fall victim to the bug.

profucius commented 1 year ago

In this issue post, Mrienstra quotes a suggestion from another message that people use the Linter plugin instead.

I've done that - uninstalled this one, installed Linter - and Linter seems to be adding the dates perfectly, as best I can tell in 24 hours.

If you're not already familiar with Linter (I wasn't), it's a much bigger plugin with many, many features. Make sure to go through and double-check that anything you don't want is turned off. Most things seem to be off by default - opt-in, not opt-out - but it can change your files so it's worth checking.

If Linter doesn't generate the created/modified frontmatter automatically, you can trigger it manually by "saving" with Ctrl-S. That works. (I'm too new to it to understand the whys and wherefores.)

I tested Linter and it worked perfectly. I only enabled the dates section settings. I like that you can make it write to all files by using the command palette and choose lint all files in vault. I went ahead and did that (after a backup) and everything I've looked at is perfect so far. Thanks again for bringing that to my attention, you saved my toosh there.

beaussan commented 1 year ago

Hi, sorry for the delay. This should now be fixed as of 2.0.0. If that's still an issue, feel free to re open a new issue !