187129573 change teacher status - Githubissues

beautyjoy / BJC-Teacher-Tracker

Access Portal and Dashboards for BJC Teachers

https://teachers.bjc.berkeley.edu

1 stars 8 forks source link

187129573 change teacher status #293

Closed ArushC closed 6 months ago

ArushC commented 7 months ago

Pivotal Tracker Link

What this PR does:

Allows changing a teacher's application status. The frontend was demonstrated at the customer meeting.

This pull request fixes|implements (pick one...) __.

Include screenshots, videos, etc.

Who authored this PR?

Arush

How should this PR be tested?

Look at the Cucumber tests. They verify that the feature works as intended.

Is there a deploy we can view?

Yes: https://sp24-01-bjc-teachers-d0e972207d82.herokuapp.com/dashboard

What do the specs/features test?
Are there edge cases to watch out for?

Are there any complications to deploying this?

Checklist:

[x] Has this been deployed to a staging environment or reviewed by a customer?
[x] Tag someone for code review (either a coach / team member)
[x] I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.29%. Comparing base (1573024) to head (def37fe).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #293 +/- ## ========================================== + Coverage 85.75% 86.29% +0.53% ========================================== Files 20 20 Lines 667 693 +26 ========================================== + Hits 572 598 +26 Misses 95 95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.