This pull request implements the multi-personal-email feature, with main changes on the view, a few changes on the backend to simplify the email processing logic, no harm on db.
Include screenshots, videos, etc.
Updates on Create Teacher Form
Based on Michael's advice, the code would be easier to manage by removing personal email field from the original form, and make it as an individual form page.
Now, even as an admin, you can't modify the personal email field in the regular form.
View
At the view Teacher page, now there is a new button to edit teacher's personal emails. And u can see the personal emails displayed at this view page, in multi lines.
Create & Updates & Delete
Error Vadalitions
Repeated Emails in the DB
Frontend Validation on Empty Values & Invalid Format
Backend Validation on Invalid Format
This needs to be done by Rspec. It's essentially validated by EmailAddress Model itself, and it's covered by the test on email_addresses_controller_spec.rb
Who authored this PR?
Perry (Jingchao) Zhong @perryzjc
Michael Tao (@realmichaeltao )
How should this PR be tested?
Is there a deploy we can view?
What do the specs/features test?
Test the Basic CRUD operations + error validation
Are there edge cases to watch out for?
Are there any complications to deploying this?
Nope
Checklist:
[ ] Has this been deployed to a staging environment or reviewed by a customer?
[x] Tag someone for code review (either a coach / team member)
[ ] I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])
perryzjc
commented
5 months ago
Original PR
Pivotal Tracker Link
What this PR does:
This pull request implements the multi-personal-email feature, with main changes on the view, a few changes on the backend to simplify the email processing logic, no harm on db.
Include screenshots, videos, etc.
Updates on Create Teacher Form
Based on Michael's advice, the code would be easier to manage by removing personal email field from the original form, and make it as an individual form page. Now, even as an admin, you can't modify the personal email field in the regular form.
View
At the view Teacher page, now there is a new button to edit teacher's personal emails. And u can see the personal emails displayed at this view page, in multi lines.
Create & Updates & Delete
Error Vadalitions
Repeated Emails in the DB
Frontend Validation on Empty Values & Invalid Format
Backend Validation on Invalid Format
This needs to be done by Rspec. It's essentially validated by EmailAddress Model itself, and it's covered by the test on
email_addresses_controller_spec.rbWho authored this PR?
How should this PR be tested?
Are there any complications to deploying this?
Nope
Checklist:
michael/12345-add-new-featureAny branch name will do as long as the story ID is there. You can usegit checkout -b [new-branch-name])