search

beaverbuilder / assistant

A tool for seeing what's happening inside WordPress and quickly navigating between pages & posts.
31 stars 5 forks source link

Fix unreachable system api #461

Closed brentjett closed 1 year ago

brentjett commented 1 year ago

The main system js file was being loaded as a module script making the FL.Assistant global API near impossible to use externally. This API needs to be available if you ever want to register an app from another plugin.

The render and apps bundles can still load as modules because they don't need to expose any public api.

brentjett commented 1 year ago

@fastlinemedia I don't think there was any reason this needed to be loaded as a module - I think I did it because its "better" in terms of cleaner on the dom. I just want a quick sanity check here to make sure I'm not forgetting something important by changing this script back to a non-module js script.