bebeal / mipnerf-pytorch

A re-implementation of mip-NeRF in PyTorch
146 stars 15 forks source link

Sampling implementation is very slow #8

Open MrMois opened 11 months ago

MrMois commented 11 months ago

For anyone using this implementation, be aware the hierarchical sampling implementation used here is very slow compared to others.

A faster one can be found here (~20x faster in my benchmark): https://github.com/yenchenlin/nerf-pytorch/blob/63a5a630c9abd62b0f21c08703d0ac2ea7d4b9dd/run_nerf_helpers.py#L196

bebeal commented 10 months ago

Ah I didn't realize it was that bad, sheesh. Will fix soon when I get time

massyzs commented 9 months ago

can you share your modified code with us? @MrMois

MrMois commented 9 months ago

Unfortunately no, but as far as I remember it was basically the code from the repo linked above. Note the 20x speedup refers to the sampling method only and not to the overall training, so do not expect wonders to happen :D