code review - Githubissues

bebebebebe / Interrupt

"Realtime" interruptible chatting in the terminal

9 stars 1 forks source link

code review #1

Open bebebebebe opened 7 years ago

bebebebebe commented 7 years ago

This pull request is a comparison of master against a branch with only the initial commit. This is to facilitate code review, since github has inline commenting available for pull requests. To use, click on the "files changed" tab above, and comment away by hovering on the '+' to the left of lines.

Inline comments can also be made on a commit level, so it's also possible to comment on the initial commit by looking at that commit individually.

Let me know if you run into issues, or questions about reviewing!

tansengming commented 7 years ago

Apologies for the comments on old files. It looks like I forgot to submit the reviews I made a few days back.

tansengming commented 7 years ago

some general comments:

I ❤️ this, it's clearly written. I'm glad I got to learn about setting up protocols with UDP.
❤️ that you made console it's own module.
Having said that I wish there were at least some tests for this. Minitest / RSpec is not hard to set up. I can help! (if you need it)
IMHO the client is going to be a PITA to test because of all the side effects. You're going to have to structure it differently to be able to test it effectively.
my one other complaint is that you should use more classes and objects. As my friend Nick says, be not afraid of classes in Ruby.