Fix: Run steps in appropriate sections

beberlei / assert

Thin assertion library for use in libraries and business-model

Other

2.41k stars 186 forks source link

Fix: Run steps in appropriate sections #157

Closed localheinz closed 8 years ago

localheinz commented 8 years ago

This PR

[x] runs build steps on Travis in appropriate sections

💁 For reference, see https://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle.

rquadling commented 8 years ago

I'm not 100% travis guru (read that as I try and get things working as best I can).

I'm collaborator on another project and they have ...

before_script:
    - travis_retry composer self-update
    - travis_retry composer update --no-interaction --prefer-source --prefer-stable ${COMPOSER_FLAGS}

The travis_retry command ... is this worth having?

localheinz commented 8 years ago

@rquadling

Never needed it, but that doesn't mean that others may not need it.

Personally, I wouldn't bother.

staabm commented 8 years ago

I would add travis_retry when your build gets unstable because of travis errors. wouldnt add it in case you didn't suffer from the problems it solves.

rquadling commented 8 years ago

Thank you.

rquadling commented 8 years ago

Looking at https://travis-ci.org/beberlei/assert/jobs/148124941, you can see there are 2 composer self-update being ran.

And this seems to have been the case for a long while! It would seem as if Travis is preparing composer for us.