search

beberlei / assert

Thin assertion library for use in libraries and business-model
Other
2.41k stars 188 forks source link

User and password on URLs can contain dots #234

Closed fedeisas closed 6 years ago

fedeisas commented 6 years ago

https://tools.ietf.org/html/rfc7617#section-2.1

rquadling commented 6 years ago

Thank you for this.

I've submitted the same issue against Symfony as that is where we got our regexes.

Once accepted there, I'll accept it here.

In the meantime, can you take a look at https://github.com/symfony/symfony/pull/24589 and copy the unit test changes please to this PR.

fedeisas commented 6 years ago

@rquadling thanks! I've copied the unit tests. It's already merged on the Symfony repo.

rquadling commented 6 years ago

Thank you for this.

rquadling commented 6 years ago

I'll do a release shortly.