search

beberlei / assert

Thin assertion library for use in libraries and business-model
Other
2.41k stars 188 forks source link

An `AssertionFailedException` must be a `Throwable` #256

Closed Ocramius closed 6 years ago

Ocramius commented 6 years ago

Since Throwable is also available starting from PHP 7.0, bumped dependency requirement, as 5.x is being retired anyway.

Ocramius commented 6 years ago

Build fails due to implicit PHPStan upgrade - probably a good idea to lock it down to ^0.9.2 for the time being

Ocramius commented 6 years ago

PHPStan now locked to ^0.9.3

Ocramius commented 6 years ago

Ref: https://github.com/phpstan/phpstan/issues/1010

rquadling commented 6 years ago

I'm going to deprecate support for PHP 5 in line with PHP, end of 2018 - http://php.net/supported-versions.php.

Ocramius commented 6 years ago

@rquadling that sounds... kinda terrible tbh, considering that people should really just rush to 7.x

rquadling commented 6 years ago

The library currently operates well. It is a shame that there are no metrics from Packagist that would allow package developers to know what versions of PHP are being used. Whilst it may not be a perfect score, having some ballpark figures would certainly be useful.

As for forcing people to move, I'm never a fan. There's little in this library that warrants deprecating support for PHP 5. If this is a critical feature for some other package, then a polyfill could do the trick.

Ocramius commented 6 years ago

https://seld.be/notes/php-versions-stats-2018-1-edition

rquadling commented 6 years ago

OK. Metrics dictate!