search

beberlei / composer-monorepo-plugin

Integrates Composer into monolithic repositories with many packages.
MIT License
305 stars 41 forks source link

Fix for BC breaking changes #81

Closed lindelius closed 1 year ago

lindelius commented 1 year ago

Fix for BC breaking changes to AutoloadGenerator introduced in https://github.com/composer/composer/pull/11663

drupol commented 1 year ago

Sorry about that colleagues!

lindelius commented 1 year ago

@beberlei would be great to get this merged, as the plugin is no longer usable after upgrading Composer to version 2.6.4

fredden commented 1 year ago

You should probably also increase the minimum supported version of composer-plugin-api, as this change won't work on older versions of Composer. https://github.com/stockfiller/composer-monorepo-plugin/blob/e2b73cbee0cea00900e716ff30bcea203d51a1ab/composer.json#L6

beberlei commented 1 year ago

For some reason the checks also did not run, do the tests pass?

And yes minimum versions need to be adjusted for plugin api and composer itself if there is a dev constraint

Seldaek commented 1 year ago

Sorry about this, no need to change anything I'll fix this in 2.6.5, I thought of moving this to the end for safety but then it got lost at some point, and now here we are 😅

drupol commented 1 year ago

Ah good idea. I can provide the fix if you want... since I introduced the issue myself, I actually don't mind doing it.

Seldaek commented 1 year ago

It's done https://github.com/composer/composer/commit/cb363b0e84459b8d280d0ff6b5a7d4ccde93420d

drupol commented 1 year ago

Excellent, looking forward for 2.6.5 ! :)