Let's talk about Metrics 2.0

[lyrixx]

fixes #24

[lyrixx]

About the lib:

• I want to remove the Factory: It does not bring something useful here. It's IMHO simpler to instantiate an object directly.
• I want to remove the functions.php. In all modern PHP application, we have a DIC or something like that.
• I want to remove the Registry. I never use it, and IMHO, it's better to inject the "right" class than an "abstraction".

What do you think?

[lyrixx]

Actually, I did not see that the Factory and the Registry where used in the Bundle. So now, I just want to remove the functions.php ;)

[lyrixx]

And finally, The bundle does't use the Factory nor the Registry anymore...

[stof]

I would rather keep tests in a separate folder rather than nesting them inside the library codebase

[lyrixx]

I would rather keep tests in a separate folder rather than nesting them inside the library codebase

Why? Symfony and lot of other lib share the same folder

[stof]

Why? Symfony and lot of other lib share the same folder

Symfony has it in the code because of the subtree splits which should include tests. Before that, they were in a separate folder

[lyrixx]

I know, But it there a valid reason to have 2 different folders? For me, tests are part of code, and so should live inside the same folder.

[adrienbrault]

Disappointed that functions.php is gone. It was awesome being able to add the metrics functions to my code without having to update tests

[lyrixx]

1/ You can still use version 1.X 2/ IMHO, it's a bad practice to use a "Singleton". It's better to inject a Collector inside your code. More over, if you don't want to update your tests, you can use this kind of code:

use Beberlei\Metrics\Collector\Collector;
use Beberlei\Metrics\Collector\Null;

class ServiceFooBar
{
    private $collector;

    public function __construct(Collector $collector = null)
    {
        $this->collector = $collector ?: new Null();
    }
//.....

I always use this "hack" for a logger / collector / ...