search

beberlei / metrics

Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.
316 stars 38 forks source link

Add support for tagging metrics? #34

Closed Shyru closed 7 years ago

Shyru commented 9 years ago

First, great library, I just thought about implementing something similar to prevent vendor lock-in. For now we will use datadog for our metric needs. StatsD (Datadog) supports adding arbitrary tags to metrics. Could that be added on the Collector API level with the default that other Collectors would not support tags? Or perhaps there are even more collectors that also support tags and could be enhanced to support tags. If we would make the parameter tags optional with an empty default value it would also be backwards compatible for all users of the library. Only the collectors would need to be modified to account for the new parameter. What do you think? (I would gladly implement this if there is a chance to include this, otherwise I will probably create my own fork)

lyrixx commented 9 years ago

Yes, it seems a good idea. Could you send a PR ?

Shyru commented 9 years ago

Yes I will try to implement that and create a pull request over the coming days.

eexit commented 9 years ago

@Shyru hey, any update on this?

kimmelserj commented 8 years ago

Perhaps, this feature is implemented in #48.

gabel commented 7 years ago

@Shyru Any news on that topic? Did you already wrote a DatadogStatsD Adapter for metric?

eexit commented 7 years ago

@Shyru @lyrixx @kimmelserj Maybe somebody wants to review #51?

eexit commented 7 years ago

I believe this issue could be closed :)

lyrixx commented 7 years ago

@eexit Yes, Thanks.