Closed davidfuhr closed 9 years ago
Do you really want to support php 5.3?
Do you need to use a feature that exist only in php 5.4+ ?
But anyway, I'm fine with bumping to 5.4+
Finally, Could you add update the symfony2 bundle? If no, don't worry, I can take care of it.
It's the library I use for InfluxDB (https://github.com/corley/influxdb-php-sdk) that requires PHP 5.4. Didn't look into it why it requires 5.4 exactly.
Would be fantastic if you could add the bundle part!
It's the library I use for InfluxDB (https://github.com/corley/influxdb-php-sdk) that requires PHP 5.4. Didn't look into it why it requires 5.4 exactly.
Ok, So there is no problem to keep this lib with php 5.3. Composer will manager that for us. You just have to skip your tests on php 5.3 (there is an anotation for that;))
Would be fantastic if you could add the bundle part!
Ok, Will do that in another PR.
Ok, So there is no problem to keep this lib with php 5.3. Composer will manager that for us. You just have to skip your tests on php 5.3 (there is an anotation for that;))
That doesn't work in this case. I tried to add --ignore-platform-reqs
to the composer install command, but unfortunately the library adds some autoload file to composer which causes phpunit to fail right away.
So i see three possible solutions:
Remove php 5.3 from travis (this is what i did in my last commit)
:+1: ;)
Could you revert this change ?
Done. :)
Thanks David for working on this feature, this is much appreciated.
Do you really want to support php 5.3?